AddressExtensions.IsPrecompiles - Extensibility#9213
Closed
svlachakis wants to merge 8 commits intofeature/arbitrum-setupfrom
Closed
AddressExtensions.IsPrecompiles - Extensibility#9213svlachakis wants to merge 8 commits intofeature/arbitrum-setupfrom
svlachakis wants to merge 8 commits intofeature/arbitrum-setupfrom
Conversation
svlachakis
changed the title
svlachakis
requested review from
AnkushinDaniil,
damian-orzechowski,
hudem1,
tanishqjasoria and
wurdum
svlachakis
changed the title
Member
|
Not sure if I like it, what do you think about alternatives and store that info in
? Similarly how |
AnkushinDaniil
approved these changes
Aug 29, 2025
Contributor
|
I strongly support Lukasz idea. It feels right. Another thing is that with the current scope of changes, supporting |
Contributor
Author
|
@damian-orzechowski @LukaszRozmej @wurdum I've implemented @LukaszRozmej 's idea since these changes are a lot and possibly risky - I definitely agree and would appreciate your thoughts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes needed for NethermindEth/nethermind-arbitrum#167
In Arbitrum we have Precompiled Addresses that need to be handled by
isPrecompilefunction inAddressExtensions.csSince the method is static and we can't put Arbitrum related logic there we need to make this method extensible.
With those changes, in Arbitrum we will implement
ArbitrumPrecompileChecker : IPrecompileCheckerand add all Arbitrum related addresses there.We will also use
CompositePrecompileCheckerin the Arbitrum plugin to combine Ethereum and Arbitrum precompiles.Types of changes
What types of changes does your code introduce?
Testing
Requires testing